search

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

Rename the operator in OLM #229

Open vpavlin opened 4 years ago

vpavlin commented 4 years ago

I have 2 issues with the recently merged PR for operator CSV

  1. The name of the operator should be kubeflow-operator not kfctl - the whole thing should be probably renamed to keep things consistent with the name of the deployment

    Right now the operator shows up as kfctl in OperatorHub - https://operatorhub.io/operator/kfctl, it would be best to make things consistent and rename it to kubeflow-operator

  2. Would it make more sense to use Kubeflow as a provider of community operator (https://github.com/kubeflow/kfctl/blob/master/deploy/olm-catalog/kfctl/0.1.0/kfctl.v0.1.0.clusterserviceversion.yaml#L92)? Since it is going to be maintained under the Kubeflow project and community, I think that would make perfect sense

@animeshsingh @Tomcli @jlewi @pdmack Thoughs?

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.74

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

pdmack commented 4 years ago

Agreed @vpavlin Also, the metadata should use the proper case of "Kubeflow"

Check [KubeFlow Operator documentation]

vpavlin commented 4 years ago
  1. addressed by https://github.com/kubeflow/kfctl/pull/270, thanks @adrian555!
jtfogarty commented 4 years ago

/area engprod /priority p2

vpavlin commented 4 years ago

@animeshsingh Any thoughts on 2.? Do you want to keep IBM in there?

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
area/kfctl 0.99

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

jlewi commented 4 years ago

I'll defer to whoever is developing the operator about what the correct values should be.