Add region information to IAM web identity role

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow

Apache License 2.0

181 stars 137 forks source link

Add region information to IAM web identity role #358

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago

Resolve https://github.com/kubeflow/kubeflow/issues/4882

User who create EKS cluster in different regions with exact same name will encounter some issues. Since we use kf-admin-${cluster-name} for web identity role and IAM is global resource. This case will break and have conflict names. It would be better for us to include region information for multi-region deployment.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label	Probability
area/kfctl	0.97
kind/feature	0.91

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

Jeffwan commented 4 years ago

/assign @Jeffwan