Fix tests for GCP blueprints 1.1

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow

Apache License 2.0

181 stars 137 forks source link

Fix tests for GCP blueprints 1.1 #375

Closed jlewi closed 4 years ago

jlewi commented 4 years ago

For workload identity binding tests the permissions were all wrong
We no longer download service account keys
cloud-endpoints-controller should be in the kubeflow namespace not istio-system namespace

Related to kubeflow/gcp-blueprints#52 Related to kubeflow/gcp-blueprints#73

kubeflow-bot commented 4 years ago

This change is

jlewi commented 4 years ago

/assign @Bobgy /assign @vpavlin /assign @animeshsingh

Bobgy commented 4 years ago

/lgtm

looks great

jlewi commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/kfctl/blob/master/OWNERS)~~ [jlewi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment