search

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

Improve AWS kfctl #379

Closed PatrickXYS closed 4 years ago

PatrickXYS commented 4 years ago

What change we make:

  1. Deleted legacy code in aws.go

  2. Since github.com/kubernetes-sigs/application deleted tag v0.8.0 (https://github.com/kubernetes-sigs/application/tags), upgrade to v0.8.1.

What test we run:

Run make build and it succeeded, then use new-built kfctl to deploy kubeflow and passed.

kubeflow-bot commented 4 years ago

This change is Reviewable

PatrickXYS commented 4 years ago

/cc @Jeffwan

Jeffwan commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/kfapp/aws/OWNERS](https://github.com/kubeflow/kfctl/blob/master/pkg/kfapp/aws/OWNERS)~~ [Jeffwan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment