search

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

Add Jeffwan as approver #387

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago

Here's the contributions. https://github.com/kubeflow/kfctl/pulls/Jeffwan

We (AWS) still uses kfctl to install Kubeflow in 1.1 version, probably 1.2 and future versions as well. I would like to put more efforts to help improve experiences for kfctl users.

I am trying to apply for approver to help community features and requests.

kubeflow-bot commented 4 years ago

This change is Reviewable

PatrickXYS commented 4 years ago

@Jeffwan has continuously contributed to kubeflow/kfctl!

jlewi commented 4 years ago

/hold

@animeshsingh @crobby @Jeffwan @vpavlin @yanniszark You are the primary maintainers/users of kfctl so you should really be the ones to approve this.

jlewi commented 4 years ago

I should probably be removed from the root OWNERs file: kubeflow/kfctl#394

animeshsingh commented 4 years ago

@Jeffwan is awesome, and has contributed greatly.

/lgtm

Jeffwan commented 4 years ago

rebase conflicts.

jlewi commented 4 years ago

I can no longer approve this change; so removing myself as a reviewer.

yanniszark commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/kfctl/blob/master/OWNERS)~~ [yanniszark] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanniszark commented 4 years ago

@animeshsingh @crobby @Jeffwan @vpavlin if everything is in order, just remove the hold :smile:

animeshsingh commented 4 years ago

/unhold