kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

Dumping generate invalid yaml #412

Closed jtherin closed 4 years ago

jtherin commented 4 years ago

Using kfctl 1.1.0 and build from master

kfctl build -d -f https://raw.githubusercontent.com/kubeflow/manifests/master/kfdef/kfctl_k8s_istio.v1.1.0.yaml

generate an invalid yaml with empty line return instead of --- between applications

Example:

kind: Namespace
metadata:
  labels:
    control-plane: kubeflow
    istio-injection: enabled
  name: kubeflow

apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  creationTimestamp: null
  labels:
    app.kubernetes.io/component: kubeflow
    app.kubernetes.io/name: kubeflow
  name: applications.app.k8s.io
spec:
  group: app.k8s.io
  names:
    kind: Application
    plural: applications
  scope: Namespaced
  validation:
    openAPIV3Schema:
      properties:
        apiVersion:
          type: string
        kind:
...

(missing --- between Namespace resource and CustomResourceDefinition resource)

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.96
area/kfctl 0.95

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

jbottum commented 4 years ago

Hi @jtherin did you get this resolved ? which platform (GCP, AWS, On-Prem) are you deploying on to ?

jtherin commented 4 years ago

I'm deploying on-prem. I pushed https://github.com/kubeflow/kfctl/pull/413 to fix it, waiting for review.