search

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

[IBM] limit reconcile requests to specific kfdef update events and a couple of operator fixes #419

Closed adrian555 closed 4 years ago

adrian555 commented 4 years ago

This PR handles these issues:

  1. when there is an update event caught for the KfDef CR, check whether they are one of the three changes to the KfDef that the operator is supposed to handle. Others will be ignored. This is done to prevent any false update to the KfDef that could cause the operator to redeploy the Kubeflow.

  2. fix the logic to check whether a namespace already exists and whether the kfdef label should be applied or not.

  3. change the master branch's operator image tag to :latest so it will not impact the current release.

kubeflow-bot commented 4 years ago

This change is Reviewable

adrian555 commented 4 years ago

cc @Tomcli @pvaneck @moficodes @animeshsingh

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrian555, moficodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/kfctl/blob/master/OWNERS)~~ [adrian555] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pvaneck commented 4 years ago

/lgtm