search

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

Add PatrickXYS as approver #423

Closed PatrickXYS closed 4 years ago

PatrickXYS commented 4 years ago

I've continuously working on kfctl and AWS will be supporting kfctl if there's no breaking change,

meanwhile, we'll help community bring back kfctl + manifest E2E test which consumes AWS resources.

Here is my contribution list:

https://github.com/kubeflow/kfctl/pulls/PatrickXYS

kubeflow-bot commented 4 years ago

This change is Reviewable

PatrickXYS commented 4 years ago

/cc @Jeffwan @animeshsingh @crobby @yanniszark @vpavlin

yanniszark commented 4 years ago

/lgtm

Jeffwan commented 4 years ago

Thanks for the contribution. /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/kfctl/blob/master/OWNERS)~~ [Jeffwan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment