search

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

kfctl build not adding status.repoCache in kfdef file #428

Open mukul-shaunik-nokia opened 4 years ago

mukul-shaunik-nokia commented 4 years ago

While trying to deploy kubeflow kubeflow version - 1.1.0 kfctl version - 1.1.0 Expected Behaviour:

kfctl build -V -f <path to CONFIG file>

should add

status: reposCache: - localPath: '".cache/manifests/manifests"' name: manifests

to the CONFIG file.

Actual Behaviour

kfctl build -V -f <path to CONFIG file>

does not add

status: reposCache: - localPath: '".cache/manifests/manifests"' name: manifests

because of that whatever changes are done before running

kfctl apply -V -f <path to CONFIG file>

are overwritten as the existing .cache folder is deleted and new one is created.

mukul-shaunik-nokia commented 4 years ago

/cc @hemantha-kumara

moficodes commented 4 years ago

I think this is current expected behavior.

@Tomcli can you confirm?

Tomcli commented 4 years ago

reposCache only appends in the apply command. I didn't own the build part so I'm not sure is this expected. But usually we shouldn't modify the .cache folder after kfctl build because all the changes should go to the generated kustomize folder.

SpontaneousDuck commented 3 years ago

So I am also seeing this issue. I am using the cache folder to customize the notebook images that are available for my user's to select. I was able to force apply to not re-pull the cache by adding the repoCache lines to my config yaml file after running build but before apply.