kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

Disable broken AWS ALB ingress status check #431

Closed PatrickXYS closed 4 years ago

PatrickXYS commented 4 years ago

For now, the AWS ALB ingress status check is broken, which is described in this issue https://github.com/kubeflow/testing/issues/779,

Disable the status check until above issue fixed

/cc @Jeffwan @yanniszark

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/kfctl/blob/master/OWNERS)~~ [PatrickXYS] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubeflow-bot commented 4 years ago

This change is Reviewable

Jeffwan commented 4 years ago

Latest stable version is 12.0. I would suggest to upgrade k8s python client and build new image. Removing the logic means we don't even check entrypoint which make test case not that helpful.

PatrickXYS commented 4 years ago

Send another PR to fix the issue

https://github.com/kubeflow/kfctl/pull/432

PatrickXYS commented 4 years ago

/close

close the PR in favor of https://github.com/kubeflow/kfctl/pull/432

k8s-ci-robot commented 4 years ago

@PatrickXYS: Closed this PR.

In response to [this](https://github.com/kubeflow/kfctl/pull/431#issuecomment-723371856): >/close > >close the PR in favor of https://github.com/kubeflow/kfctl/pull/432 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.