search

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

Cherry-pick of #439 and #440 to v1.2-branch #441

Closed pvaneck closed 4 years ago

pvaneck commented 4 years ago

This cherry-picks #439 and #440 in to v1.2-branch.

pvaneck commented 4 years ago

/cc @PatrickXYS

PatrickXYS commented 4 years ago

/lgtm /approve

Thanks @pvaneck !

PatrickXYS commented 4 years ago 
           HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"deployments.apps \"metadata-ui\" not found","reason":"NotFound","details":{
"name":"metadata-ui","group":"apps","kind":"deployments"},"code":404}

This is because this PR is not yet cherry-picked https://github.com/kubeflow/kfctl/pull/440

pvaneck commented 4 years ago

@PatrickXYS Want me to cherry-pick that in this PR?

PatrickXYS commented 4 years ago

@pvaneck I sent a PR as of now, https://github.com/kubeflow/kfctl/pull/442, can you lgtm?

pvaneck commented 4 years ago

@PatrickXYS I cherry-picked #440 here as well.

PatrickXYS commented 4 years ago

/lgtm /approve /hold Hold until test succeed

Thanks @pvaneck !

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatrickXYS, pvaneck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/kfctl/blob/v1.2-branch/OWNERS)~~ [PatrickXYS] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
PatrickXYS commented 4 years ago

@pvaneck Feel free to unhold to merge the PR

pvaneck commented 4 years ago

/unhold