search

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

Fix csv version #448

Closed evan-hataishi closed 4 years ago

evan-hataishi commented 4 years ago

Fixes the file name as described in one of the tasks in https://github.com/kubeflow/kfctl/issues/422.

CSV generated with operator-sdk 0.16 Tested on OCP 4.5 with this kfdef

aws-kf-ci-bot commented 4 years ago

Hi @evan-hataishi. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Tomcli commented 4 years ago

/ok-to-test

Tomcli commented 4 years ago

@evan-hataishi so no code changes for 1.1 release except the filename?

evan-hataishi commented 4 years ago

@evan-hataishi so no code changes for 1.1 release except the filename?

@Tomcli Nope, just a fix for the filename.

Tomcli commented 4 years ago

@evan-hataishi how about for 1.2? I think we will have the official 1.2 release this week.

evan-hataishi commented 4 years ago

@Tomcli It looks like we're keeping track of all the versions, so I'll work on that next and put it in a new PR

Tomcli commented 4 years ago

I see, it looks like the olm Kubeflow 1.1 release was using the old name. This probably fix that bug. /lgtm

Jeffwan commented 4 years ago

Seems this is OLM only.

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evan-hataishi, Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/kfctl/blob/master/OWNERS)~~ [Jeffwan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment