search

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow
Apache License 2.0
181 stars 137 forks source link

Add new csv and update operator to version 1.2.0 #457

Closed evan-hataishi closed 3 years ago

evan-hataishi commented 4 years ago

Resolves https://github.com/kubeflow/kfctl/issues/422

Operator image v1.2.0 built and pushed to dockerhub.

aws-kf-ci-bot commented 4 years ago

Hi @evan-hataishi. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Tomcli commented 4 years ago

/ok-to-test

Tomcli commented 4 years ago

Thanks @evan-hataishi, it looks good to me. Do you also have a PR that updates it on the operatorHub?

evan-hataishi commented 4 years ago

@Tomcli I'll look into this now and submit a PR to operatorhub as well.

evan-hataishi commented 4 years ago

@Tomcli Added to operatorhub in https://github.com/operator-framework/community-operators/pull/2734

adrian555 commented 4 years ago

@evan-hataishi at least the alm-examples in the csv file needs to update and reflect the kfdef 1.2.0. And test the operator on k8s cluster.

Tomcli commented 4 years ago

Thanks @evan-hataishi /lgtm

evan-hataishi commented 3 years ago

This csv has been merged in https://github.com/operator-framework/community-operators/pull/2734, so both repositories should be in sync after this is merged.

Tomcli commented 3 years ago

thanks @evan-hataishi /lgtm

adrian555 commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrian555, evan-hataishi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/kfctl/blob/master/OWNERS)~~ [adrian555] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment