Add ownerReferences to resources

kubeflow / kfctl

kfctl is a CLI for deploying and managing Kubeflow

Apache License 2.0

181 stars 137 forks source link

Add ownerReferences to resources #490

Closed VaishnaviHire closed 2 years ago

VaishnaviHire commented 3 years ago

Closes #460 This commit is responsible for following changes:

Adds owner references to all the resources in the manifest repo.
It also removes the kfctl.kubeflow.io/kfdef-instance: <kfdef-name>.<kfdef-namespace> annotation, since its no longer required. The owner references field now indicates that resources are owned by KfDef instance.

Ref PR: https://github.com/kubeflow/kfctl/pull/271

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VaishnaviHire To complete the pull request process, please assign yanniszark after the PR has been reviewed. You can assign the PR to them by writing /assign @yanniszark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/kfctl/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

aws-kf-ci-bot commented 3 years ago

Hi @VaishnaviHire. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

crobby commented 3 years ago

/ok-to-test

VaishnaviHire commented 3 years ago

Adding ownerReferrences without changing the scope of the KfDef crd to Cluster is not possible from v1.20

Cross-namespace ownerreferences are disallowed and dependent objects are subject to deletion. This PR needs to be revisited, once the scope of KfDef is updated.

VaishnaviHire commented 3 years ago

/hold