kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Update kserve manifests from v0.11.2 (#2627) and synchronize from the 1.8 branch #2633

Closed juliusvonkohout closed 4 months ago

juliusvonkohout commented 4 months ago

@rimolive

cherry pick Update kubeflow/kubeflow manifests from v1.8.0 (#2567)

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juliusvonkohout commented 4 months ago

We should drop

# If you want to install both KFServing and KServe, install the
# standalone kserve manifests, to avoid conflicts with 0.6.1 KFServing.
# - kserve.yaml
# - aggregated-roles.yaml
# - kserve-runtimes.yaml
# configMapGenerator:
#   - name: kserve-config
#     namespace: kserve
#     behavior: merge
#     envs:
#     - params.env

from the main kustomization.yaml since KFserving is gone.

https://github.com/kubeflow/manifests/blob/7c2de6bbfd486919b36d519f08393399758c30c8/tests/gh-actions/install_kserve.sh should be rewritten to clearly separate the CRD installation and wait after that.

rimolive commented 4 months ago

Is this required for 1.8.1?

juliusvonkohout commented 4 months ago

Is this required for 1.8.1?

no for 1.9. The merge just started the wrong way. we should always update master first and backport to older branches as for example 1.8. So this time i have to make a forward-port.