search

kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Update README.md #2645

Closed tiansiyuan closed 3 months ago

tiansiyuan commented 3 months ago

Which issue is resolved by this Pull Request: Resolves #

Description of your changes:

Put the answer of the 2ed question of FAQ into a separate line.

Checklist:

juliusvonkohout commented 3 months ago

CC @diegolovison

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: diegolovison, tiansiyuan Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juliusvonkohout commented 3 months ago

I think this was fixed in master in another PR recently. Please rebase and check again.

juliusvonkohout commented 3 months ago

This is already updated in the master and neither CLA nor DCO are signed.

juliusvonkohout commented 3 months ago

@tiansiyuan Please join the slack channel wg-manifests and our regaular meetings (tomorrow as well) if you want to propose new things

https://www.kubeflow.org/docs/about/community/