search

kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Fixes kubeflow-issuer for kustomize 5 #2657

Closed alekseyolg closed 3 months ago

alekseyolg commented 3 months ago

While the command is running:

kustomize build common/cert-manager/kubeflow-issuer/base

A warning appeared:

# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

I used the command:

kustomize edit fix --vars

And also corrected errors received when executing this command. Manifests are now generated without warnings.

Please note that this PR should not affect the manifests themselves in any way, only the warning is removed.

Checklist:

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alekseyolg Once this PR has been reviewed and has the lgtm label, please assign kkasravi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[common/cert-manager/OWNERS](https://github.com/kubeflow/manifests/blob/master/common/cert-manager/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment