search

kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
807 stars 869 forks source link

Reorder oauth2-proxy manifests so that namespace is first #2668

Closed codablock closed 5 months ago

codablock commented 5 months ago

Description of your changes: This ensures that the namespace is always deployed before anything else, even if fifo ordering is used with Kustomize.

Checklist:

juliusvonkohout commented 5 months ago

Sorry, our CICD is currently too slow for some tests.

codablock commented 5 months ago

@juliusvonkohout Are you sure that slowliness is the cause of the failure? I see Python import errors in the logs...

If I remember correct, the individual GH workflows are only run on source changes in specific folders, and also only on PRs. This can easily lead to non-working workflows that get unnoticed for quite some time. If you want, I can try to investigate when I find time?

juliusvonkohout commented 5 months ago

@juliusvonkohout Are you sure that slowliness is the cause of the failure? I see Python import errors in the logs...

If I remember correct, the individual GH workflows are only run on source changes in specific folders, and also only on PRs. This can easily lead to non-working workflows that get unnoticed for quite some time. If you want, I can try to investigate when I find time?

Yes, @kromanov is investigating as well. In other PRs it is failing for different reasons. But rebasing your PR to master and checking test_sklearn.py is a good idea.

juliusvonkohout commented 5 months ago

@codablock please rebase to master since https://github.com/kubeflow/manifests/actions/runs/8897758758/job/24433376331?pr=2698 was succesful

juliusvonkohout commented 5 months ago

/approve /lgtm

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codablock, juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[common/oidc-client/oauth2-proxy/OWNERS](https://github.com/kubeflow/manifests/blob/master/common/oidc-client/oauth2-proxy/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment