Update kubeflow/model-registry manifests from v0.2.0-alpha

kubeflow / manifests

A repository for Kustomize manifests

Apache License 2.0

772 stars 836 forks source link

Update kubeflow/model-registry manifests from v0.2.0-alpha #2697

Closed rimolive closed 1 month ago

rimolive commented 2 months ago

Which issue is resolved by this Pull Request: Supersedes #2694

Description of your changes:

Checklist:

[x] Unit tests pass: Make sure you have installed kustomize == 5.2.1+
1. make generate-changed-only
2. make test

juliusvonkohout commented 2 months ago

We should update the model registry synchronization script as I did for Katib in https://github.com/kubeflow/manifests/pull/2698

lampajr commented 2 months ago

Thanks @rimolive, note that the manifests README and OWNERS files that have been added with https://github.com/kubeflow/model-registry/pull/69 were not included in v0.2.0-alpha tag yet (as the PR has been merged yesterday).

As temporary solution, if really needed, we could add them manually as part of this PR. Wdyt?

rimolive commented 1 month ago

@lampajr Done

rimolive commented 1 month ago

/hold

Found an issue in the sync script.

rimolive commented 1 month ago

/unhold

rimolive commented 1 month ago

cc @juliusvonkohout

juliusvonkohout commented 1 month ago

networkpolicies etc. in follow up PRs

/lgtm /approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, lampajr, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment