Update kubeflow/training-operator manifests from v1.8.0-rc.0

kubeflow / manifests

A repository for Kustomize manifests

Apache License 2.0

807 stars 869 forks source link

Update kubeflow/training-operator manifests from v1.8.0-rc.0 #2699

Closed rimolive closed 4 months ago

rimolive commented 5 months ago

Which issue is resolved by this Pull Request: Resolves #

Description of your changes:

Checklist:

[x] Unit tests pass: Make sure you have installed kustomize == 5.2.1+
1. make generate-changed-only
2. make test

juliusvonkohout commented 5 months ago

Yes, I think we should streamline the synchronization script here as well. Feel also free to change it as long as you change all scripts accordingly.

rimolive commented 4 months ago

@juliusvonkohout I updated the sync script. Would you mind take a look?

juliusvonkohout commented 4 months ago

i did not check the added rbac roles, but that is something for the training operator folks

For synchronizing and rc0 /lgtm /approve

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment