Fix kserve upgrade script and update kserve diagram

kubeflow / manifests

A repository for Kustomize manifests

Apache License 2.0

772 stars 836 forks source link

Fix kserve upgrade script and update kserve diagram #2702

Closed sivanantha321 closed 1 month ago

sivanantha321 commented 1 month ago

Which issue is resolved by this Pull Request: Resolves # Kserve recently renamed the release artifact from kserve-runtimes.yaml to kserve-cluster-resources.yaml. However, the Makefile still references the old one. This PR resolves this issue.

This PR also updates the kserve diagram.

Description of your changes:

Checklist:

[ ] Unit tests pass: Make sure you have installed kustomize == 5.2.1+
1. make generate-changed-only
2. make test

juliusvonkohout commented 1 month ago

Hhm on a first glimpse it looks as if there are synchronisation scripts in two places. @rimolive we probably should take a closer look

juliusvonkohout commented 1 month ago

It is definitely not perfect, but at least an improvement. Ill remove the makefile in another PR since we have the synchronization script.

/lgtm /approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, sivanantha321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[contrib/kserve/OWNERS](https://github.com/kubeflow/manifests/blob/master/contrib/kserve/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment