search

kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Rebase 1.9 to master #2712

Closed juliusvonkohout closed 1 month ago

juliusvonkohout commented 1 month ago

Rebase to master

juliusvonkohout commented 1 month ago

/hold

juliusvonkohout commented 1 month ago

Lets wait for https://github.com/kubeflow/manifests/pull/2713 first to fix the DCO

juliusvonkohout commented 1 month ago

/approve /lgtm

google-oss-prow[bot] commented 1 month ago

@juliusvonkohout: you cannot LGTM your own PR.

In response to [this](https://github.com/kubeflow/manifests/pull/2712#issuecomment-2107423879): >/approve >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
juliusvonkohout commented 1 month ago

/unhold

lampajr commented 1 month ago

/lgtm /approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, lampajr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/manifests/blob/v1.9-branch/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment