search

kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Fixes for dco changes #2713

Closed juliusvonkohout closed 1 month ago

juliusvonkohout commented 1 month ago

@lampajr something in your commits confused the DCO later on or the DCO checks were changed. Probably the latter. I signed them off again. See https://github.com/kubeflow/manifests/runs/24884888875

Plaese check and

/lgtm

juliusvonkohout commented 1 month ago

Afterwards we can adjust and merge https://github.com/kubeflow/manifests/pull/2712 for the 1.9.0-rc1 release.

lampajr commented 1 month ago

/lgtm

StefanoFioravanzo commented 1 month ago

@juliusvonkohout your signoffs use a weird email (probably the GitHub user ID email). Is this intended?

juliusvonkohout commented 1 month ago

@juliusvonkohout your signoffs use a weird email (probably the GitHub user ID email). Is this intended?

Yes, i do not want more spam :-D

juliusvonkohout commented 1 month ago

DCO tests are passing. Lets hope the master branch will be happy as well.

/approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, lampajr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lampajr commented 1 month ago

DCO tests are passing. Lets hope the master branch will be happy as well.

It seems not :face_with_diagonal_mouth:

lampajr commented 1 month ago

DCO tests are passing. Lets hope the master branch will be happy as well.

It seems not 🫤

Nevermind, now it is green! :tada: