search

kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Update istio to v1.22.0-beta.1 #2714

Closed biswajit-9776 closed 1 month ago

biswajit-9776 commented 1 month ago

Description of your changes: Update of istio to version 1.22.0-beta.1

Checklist:

juliusvonkohout commented 1 month ago
  1. You need to sign with DCO as explained here https://github.com/kubeflow/manifests/pull/2714/checks?check_run_id=24899922386
  2. Rebase to master and check that all changed workflows are in line with e.g. https://github.com/kubeflow/manifests/blob/4547b2f32da9b1f4163c30dcd4a1329ec589d5bc/.github/workflows/notebook_controller_m2m_test.yaml#L11C9-L11C25 and https://github.com/kubeflow/manifests/commit/365cdff1a9cc94c04171ad4ec9f25ed068a1ffe2
  3. https://github.com/istio/istio/releases/tag/1.22.0-rc.0 is already there
diegolovison commented 1 month ago

Hello, how this update is done? Are they copying and pasting files?

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from juliusvonkohout. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juliusvonkohout commented 1 month ago

Hello, how this update is done? Are they copying and pasting files?

It is explained in the readme.

juliusvonkohout commented 1 month ago

If you do not manage to fix the tests this week you can also try Istio 1.21 first.

biswajit-9776 commented 1 month ago

If you do not manage to fix the tests this week you can also try Istio 1.21 first.

@juliusvonkohout Do you believe the tests/gh-actions/install_multi_tenancy.sh and similar tests are failing due to the istio-1.22.0.beta-1? If that is so, I can create another PR for upgrading istio to v1.21.0 .

juliusvonkohout commented 1 month ago

If you do not manage to fix the tests this week you can also try Istio 1.21 first.

@juliusvonkohout Do you believe the tests/gh-actions/install_multi_tenancy.sh and similar tests are failing due to the istio-1.22.0.beta-1? If that is so, I can create another PR for upgrading istio to v1.21.0 .

That is something to find out by running them locally.

juliusvonkohout commented 1 month ago

But yes, you can also open a separate Pr for 1.21 and see which one works better.