search

kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Add node-red examples to /contrib #2723

Open sefgsefg opened 1 month ago

sefgsefg commented 1 month ago

We made two examples that using Node-red to control kubeflow pipeline

We use Node-red to create a user interface that allows users to select pipeline execution parameters through node settings. The process includes program code execution, YAML file compilation, automatic pipeline file upload, and data return, reducing user operation time.

Of course, users can also create their own Node-red interface through sample templates to meet their needs.

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juliusvonkohout commented 1 month ago

Hello, you need to sign the DCO and rebase to master.

Before merging this, we first need to get actual node-red manifests or platform stuff, because this is the manifests/platform repository. As explained in the manifests WG meetings we need something similar to the Kserve or Ray integration.

https://github.com/kubeflow/manifests/tree/master/contrib/kserve there is UI integration and Kustomize stuff with Kubernetes deployments etc.

Furthermore, where is all of this coming from? What is your organizations base repository?

CC @kimwnasptd @rimolive @andreyvelich

sefgsefg commented 1 month ago

I have sign-off the DCO but it still get error. Is there any problem I don't solve?

juliusvonkohout commented 1 month ago

I have sign-off the DCO but it still get error. Is there any problem I don't solve?

Please take a look at the output of the DCO check https://github.com/kubeflow/manifests/pull/2723/checks?check_run_id=25255505195 by clicking on the details button.