kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Missing mycluster.yaml #2738

Open tiansiyuan opened 3 weeks ago

tiansiyuan commented 3 weeks ago

Validation Checklist

Version

1.9

Describe your issue

In the README.md file, script to create Kind cluster refers to mycluster.yaml:

cat <<EOF | kind create cluster --name=kubeflow  --kubeconfig mycluster.yaml --config=-
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
  image: kindest/node:v1.28.0
  kubeadmConfigPatches:
  - |
    kind: ClusterConfiguration
    apiServer:
      extraArgs:
        "service-account-issuer": "kubernetes.default.svc"
        "service-account-signing-key-file": "/etc/kubernetes/pki/sa.key"
EOF

But this file is missing.

It is better to give an example of this file.

Steps to reproduce the issue

Read README.md file.

Put here any screenshots or videos (optional)

n/a

juliusvonkohout commented 3 weeks ago

CC @diegolovison

diegolovison commented 3 weeks ago

Hi @tiansiyuan

What is the error?

tiansiyuan commented 3 weeks ago

Need a sample of the mycluster.yaml file while creating a kind cluster.

diegolovison commented 3 weeks ago

Sorry, but I don't see the issue. Please provide the error from your terminal.

rimolive commented 3 weeks ago

I think this file is not required, because after you create your cluster you can simply follow the steps to replace your default kubeconfig with the one from the KinD cluster you just created.

@diegolovison Any idea why this flag is required? Otherwise, can we remove?