kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Upgrading istio to v1.18.7 #2739

Closed biswajit-9776 closed 3 weeks ago

biswajit-9776 commented 3 weeks ago

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I updated istio version 1.17.5 to 1.18.7

πŸ“¦ List any dependencies that are required for this change

My PR depends on #

πŸ› If this PR is related to an issue, please put the link of the issue here.

The following issues are related, because ...

βœ… Unit Test Checklist

βœ… Contributor checklist


You can join our slack channel wg-manifests here. This link also contains our meeting schedule.

juliusvonkohout commented 3 weeks ago

TODO:

rimolive commented 3 weeks ago

I'm not sure if the TODO items are missing work items for this PR, but if the tests passed I think we're good to move on. I'll lgtm but will hold to merge until @juliusvonkohout approves.

/lgtm /hold

juliusvonkohout commented 3 weeks ago

TODO:

* Update istio-cni to 1.18.7 as well

* delete the istio 1.17 folders

* fix all tests

* Update the readme

* Transform the readme into a script as we have it in /hack to upgrade synchronize istio manifests in an automated manner next time

* For istio-cni we need a script as well

* use the script to update to in several PRs to 1.19, then 1.20, then 1.21 and 1.22 for istio and istio-cni

@biswajit-9776 lets continue this in a new PR then such that we can cut RC.1

juliusvonkohout commented 3 weeks ago

/lgtm /approve

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juliusvonkohout commented 3 weeks ago

/unhold