search

kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
772 stars 836 forks source link

Upgraded istio to v1.19.10 #2743

Closed biswajit-9776 closed 3 weeks ago

biswajit-9776 commented 3 weeks ago

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I upgraded istio from version 1.18.7 to 1.19.10

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link of the issue here.

The following issues are related, because ...

✅ Unit Test Checklist

✅ Contributor checklist

You can join our slack channel wg-manifests here. This link also contains our meeting schedule.

juliusvonkohout commented 3 weeks ago

Please also fix the Readme based on your experience with the upgrade for istio and istio-cni in this PR.

juliusvonkohout commented 3 weeks ago

/ok-to-test

biswajit-9776 commented 3 weeks ago

Let me upgrade istio-cni and push it in this same PR.

biswajit-9776 commented 3 weeks ago

I pushed this PR with two scripts which I think could push after the v1.22.0 upgradation.

juliusvonkohout commented 3 weeks ago

I pushed this PR with two scripts which I think could push after the v1.22.0 upgradation.

I do not see the two scripts in /hack Please add them in the next PR

/lgtm /approve

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
biswajit-9776 commented 3 weeks ago

Yes I will push the two scripts in the upcoming PRs.