search

kubeflow / manifests

A repository for Kustomize manifests
Apache License 2.0
806 stars 869 forks source link

fix: update /models/ to /kserve-endpoints/ for kserve models web app … #2752

Closed OussemaLouati closed 3 months ago

OussemaLouati commented 3 months ago

Fix KServe model endpoints webapp Url.

Description

Update centraldashboard-config ConfigMap to point to the right link based on this VirtualService

Using /models/ will result in the following screen when deploying Kubeflow

models-invalid

After Updating the ConfigMap to use /kserve-endpoints/, the Models endpoint will show correctly:

kserve-fixed

Note: Instead of updating the ConfigMap centraldashboard-config we can update the actual VirtualService to use /models/ instead also.

juliusvonkohout commented 3 months ago

It seems to have been changed in https://github.com/kubeflow/manifests/commit/fb440d82c6996f5e39ea153b76319acfdf1aa805

@diegolovison can you test whether it works in the current master branch ?

CC @rimolive

juliusvonkohout commented 3 months ago

CC @kimwnasptd

diegolovison commented 3 months ago

@diegolovison can you test whether it works in the current master branch ?

yes, I can but I have a question. Are we going to backport to 1.9 as well?

juliusvonkohout commented 3 months ago

@diegolovison can you test whether it works in the current master branch ?

yes, I can but I have a question. Are we going to backport to 1.9 as well?

we have to get this into the next 1.9 RC for kubeflow/kubeflow.

rimolive commented 3 months ago

/lgtm

I tested and it worked.

juliusvonkohout commented 3 months ago

/approve

tested by ricardo.

this is not the proper fix. It has to be fixed in kubeflow/kubeflow and it will hit us again on the next kubeflow/kubeflow synchronization. But for now we need to be able to release the next RC.

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juliusvonkohout commented 3 months ago

There is a PR to fix it https://github.com/kubeflow/kubeflow/pull/7603