kubeflow / manifests

A repository for Kustomize manifests

Apache License 2.0

772 stars 836 forks source link

Convert trivy_scan.sh into python #2758

Closed hansinikarunarathne closed 4 days ago

hansinikarunarathne commented 6 days ago

Pull Request Template for Kubeflow manifests Issues

Please include a summary of changes and the related issue.
List any dependencies that are required for this change.
Please delete the options that are not relevant.
The following checklist will help you to satisfy the requirements.

✏️ A brief description of the changes

Convert trivy_scan.sh file fully into python
Implemented the same functionality in trivy_scan.sh file in python

✅ Contributor checklist

[X] All the commits have been signed-off (To pass the DCO check)
[X] Submit the Contributor License Agreements (To pass the cla/google check)

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

juliusvonkohout commented 5 days ago

Does trivy.sh and trivy.py produce the exact same output? Please check that once and upload it here if possible.

hansinikarunarathne commented 5 days ago

Below is the output of the trivy_scan.py

Below is the output of the trovy_scan.sh

There was an additional image in the manifest when running trivy_scan.py. I checked it and it is because there was a failure for that image when ran trivy_scan.sh. It is passed in the trivy_scan.py .

juliusvonkohout commented 5 days ago

Amazing, did you get rid of the kustomize error messages? Please also adjust the github workflow such that it is triggered in this PR.

hansinikarunarathne commented 4 days ago

Amazing, did you get rid of the kustomize error messages? Please also adjust the github workflow such that it is triggered in this PR.

I failed to get rid of the customize errors. And I documented those errors https://docs.google.com/document/d/1tP7FyIIXR1WziagqsZjgBNQ1d0YbdJOe30qoi_SqPA0/edit?usp=sharing
I adjust the github workflow in the way to triggered in this PR

juliusvonkohout commented 4 days ago

Please do not use .gitkeep, but generate the directory in python

juliusvonkohout commented 4 days ago

/lgtm /approve

google-oss-prow[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/manifests/blob/master/OWNERS)~~ [juliusvonkohout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment