Reorganize Kubeflow tests

kromanow94 commented 4 months ago

Validation Checklist

[X] Is this a Kubeflow issue?
[X] Are you posting in the right repository ?
[X] Did you follow the installation guide https://github.com/kubeflow/manifests?tab=readme-ov-file ?
[X] Is the issue report properly structured and detailed with version numbers?
[X] Is this for Kubeflow development ?
[X] Would you like to work on this issue?
[X] You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Version

master

Describe your issue

The tests for the Kubeflow Components are currently placed either in the GitHub Actions Workflow Templates or under the tests/gh-actions path, or under contrib in an unorganized manner. It's confusing and lacks organization. There should be well-organized place or alignment for the tests. Those should preferably run with a testing framework like pytest. If we were to improve this situation, we can start implementing a more robust and flexible test framework that can be simply run from GH Actions or in the user development environment.

To point a few tests that could be reorganized:

Additionally, some of the components lacks a proper e2e tests. Here is the list of GH Actions that performs sanity tests by just deploying the manifests on the cluster but are not providing any more insights than that:

Additionally, we could start using some nice utilities like pre-commit to automatically run some actions like linters, formatters, check if commit is signed and potentially more. Then, such a pre-commit configuration could be used both from the GH Actions and from the Developer Environment. These are the GH Actions that could benefit from this pattern:

This was recently touched upon here: 2795#discussion_r1674228094.

Steps to reproduce the issue

N/A

juliusvonkohout commented 4 months ago

Let's discuss this in the next kubeflow platform meeting :-)

juliusvonkohout commented 4 months ago

@hansinikarunarathne is also working on this and has a draft. Can we maybe merge both issues?

kromanow94 commented 4 months ago

@juliusvonkohout sounds like a good plan. I can share a few thoughts on where and how I think this should head. We can talk at the next KF Platform/Manifests WG Meeting.

juliusvonkohout commented 4 months ago

I think https://docs.google.com/document/d/1FSbGDPko3rZ77oU5F4xxDwGhzgfYbvq5kX-ZciUzaT4/edit?usp=sharing is the document from @hansinikarunarathne

juliusvonkohout commented 3 months ago

Reopen after merging https://github.com/kubeflow/manifests/pull/2805

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

juliusvonkohout commented 1 month ago

/lifecycle frozen

kubeflow / manifests