[Frontend] Standardize code style using prettier

kubeflow / metadata

Repository for assets related to Metadata.

Apache License 2.0

121 stars 69 forks source link

[Frontend] Standardize code style using prettier #141

Open kwasi opened 4 years ago

kwasi commented 4 years ago

A kubeflow/metadata version of kubeflow/pipelines issue #2406.

As mentioned in that issue, Prettier will save formatting cycles in code review. It can also be setup with a file watcher to auto-format changed lines or files on save.

Sub-tasks

[ ] Create a Prettier config
[ ] Allow a week for comments on the config
[ ] Format the whole code base after syncing with people with PRs in flight
[ ] Add a section on code style to frontend/README.md

The last sub-task is blocked by updating the README.md file (#140).

Bobgy commented 4 years ago

Thanks for putting these together!

For sync with kubeflow/pipelines. I recommend we use the same config as https://github.com/kubeflow/pipelines/blob/master/frontend/.prettierrc.yaml

trailingComma: all
singleQuote: true
jsxSingleQuote: true
printWidth: 100

Let me know if there's anything you want to change. We can discuss and adjust the config back to kubeflow/pipelines too.

kwasi commented 4 years ago

Sounds good! We definitely want to keep all the frontend projects in sync so we'll start with your .prettierrc.yaml.

jtfogarty commented 4 years ago

/area front-end /kind feature /priority p2