kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

Python SDK improvements #167

Closed zhenghuiwang closed 4 years ago

zhenghuiwang commented 4 years ago

This PR improves current Python SDK:

Testing:


This change is Reviewable

zhenghuiwang commented 4 years ago

/test kubeflow-metadata-presubmit

zhenghuiwang commented 4 years ago

/assign @jinchihe @gaoning777

It is ready for your review. Thanks

jinchihe commented 4 years ago

Would please update new version in setup.py file so that we can release new pkg in Pypi for the two new big enhancements? Others look good to me.

zhenghuiwang commented 4 years ago

Would please update new version in setup.py file so that we can release new pkg in Pypi for the two new big enhancements? Others look good to me.

Thanks @jinchihe . setup.py is already 0.3.0. (PyPI has 0.2.0) So no need to change it.

I can publish 0.3.0 once this PR is landed.

jinchihe commented 4 years ago

@zhenghuiwang Great. /lgtm

zhenghuiwang commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhenghuiwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[sdk/OWNERS](https://github.com/kubeflow/metadata/blob/master/sdk/OWNERS)~~ [zhenghuiwang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment