kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

Add LineageViewActionBar #170

Closed kwasi closed 4 years ago

kwasi commented 4 years ago

Feature

Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZV4FTvhm3v2g/files/MCEJu8Y2hyDScc3J36YgKln9aLSFm3NIoRQ

Implementation

Fixes #147

Screencast https://screencast.googleplex.com/cast/NTgxNjQ1NjMxNjk3NzE1Mnw4YTQ1MmY5ZC01MQ

Dev Deployment https://kubeflow-ui-07e.endpoints.kwasinti-kubeflow-dev.cloud.goog/_/metadata/#/artifacts

How fake is the data?

This is still using fake data but using real types. LineageView.tsx renders the target card using the real ml_metadata.Artifact object loaded with ArtifactDetails. When a <LineageCardRow /> with fake data is clicked, an ml_metadata.Artifact is created at runtime an used as the new target Artifact to breadcrumb state. Once the LineageView cards have access to an Artifact, they should be able to pass it up with no further changes.


This change is Reviewable

kwasi commented 4 years ago

/assign @avdaredevil

avdaredevil commented 4 years ago

/lgtm /approve /hold

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avdaredevil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/kubeflow/metadata/blob/master/frontend/OWNERS)~~ [avdaredevil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
avdaredevil commented 4 years ago

/lgtm

avdaredevil commented 4 years ago

/hold cancel