Closed kwasi closed 4 years ago
/assign @avdaredevil
/lgtm /approve /hold
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: avdaredevil
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/hold cancel
Feature
Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZV4FTvhm3v2g/files/MCEJu8Y2hyDScc3J36YgKln9aLSFm3NIoRQ
Implementation
Fixes #147
Screencast https://screencast.googleplex.com/cast/NTgxNjQ1NjMxNjk3NzE1Mnw4YTQ1MmY5ZC01MQ
Dev Deployment https://kubeflow-ui-07e.endpoints.kwasinti-kubeflow-dev.cloud.goog/_/metadata/#/artifacts
How fake is the data?
This is still using fake data but using real types.
LineageView.tsx
renders the target card using the realml_metadata.Artifact
object loaded withArtifactDetails
. When a<LineageCardRow />
with fake data is clicked, anml_metadata.Artifact
is created at runtime an used as the new target Artifact to breadcrumb state. Once theLineageView
cards have access to an Artifact, they should be able to pass it up with no further changes.This change is