Fix initial state of LineageViewActionBar

kubeflow / metadata

Repository for assets related to Metadata.

Apache License 2.0

121 stars 69 forks source link

Fix initial state of LineageViewActionBar #177

Closed kwasi closed 4 years ago

kwasi commented 4 years ago

Before: https://screenshot.googleplex.com/JtEJ8TJBdEV After: https://screenshot.googleplex.com/iZNqVrsKkjc

Pass ArtifactDetails state artifact to <LineageView />. Artifact is guaranteed to be loaded before attempting to render <LineageView />
Make target a required property to render <LineageView />

This change is

kwasi commented 4 years ago

/assign @avdaredevil

kwasi commented 4 years ago

/area front-end /area metadata

avdaredevil commented 4 years ago

Looks great! /lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avdaredevil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/kubeflow/metadata/blob/master/frontend/OWNERS)~~ [avdaredevil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment