kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

Add a MLMD context for every `workspace` & update notebook example #178

Closed zhenghuiwang closed 4 years ago

zhenghuiwang commented 4 years ago

What this PR does / why we need it: workspace is for group relevant metadata together. MLMD recently added generic Context&ContextType for the same purpose.

This PR adds one context for each workspace to enable fast metadata retrieval via context. Current way of adding workspace name as artifact property shall be gradually phased out in the future.(Current UI still needs it)

Changes:


This change is Reviewable

zhenghuiwang commented 4 years ago

/retest

zhenghuiwang commented 4 years ago

@jinchihe and @gaoning777 This PR is ready for your review! thanks

jinchihe commented 4 years ago

@zhenghuiwang Thanks. Sounds great!

/lgtm

zhenghuiwang commented 4 years ago

Thanks for the review! /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhenghuiwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/metadata/blob/master/OWNERS)~~ [zhenghuiwang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment