[Windows] Changes to allow docker building on windows

avdaredevil commented 4 years ago

About

npm run docker now runs a new script called ./docker_build.js which will create the docker images cross-platform
The docker build script does handle dates slightly differently: (instead of using date -u we now use js' new Date().toUTCString())
- No double space between month and date
- An extra comma is removed after the date
- UTC uses 24h clock instead of 12hr with AM / PM

Release note:

Windows support for building node images, cross-platform node scripts

Meta

/area metadata /area front-end /priority p1 /assign @avdaredevil /cc @kwasi

This change is

kwasi commented 4 years ago

/lgtm /approve

Looks great! Just a couple nits

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwasi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/kubeflow/metadata/blob/master/frontend/OWNERS)~~ [kwasi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubeflow / metadata

[Windows] Changes to allow docker building on windows #180

About

Meta