search

kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

Add third party licenses into docker image #182

Closed zhenghuiwang closed 4 years ago

zhenghuiwang commented 4 years ago

To comply with the license requirements, such as BSD-3 or MIT, of third party dependencies, we need to copy all license contents into the docker images.

This PR adds instructions&scripts to gather these license information.

Related to: kubeflow/testing#539

This change is Reviewable

zhenghuiwang commented 4 years ago

/cc @jlewi @abhi-g

neuromage commented 4 years ago

/lgtm /approve

jlewi commented 4 years ago

/lgtm /approve

zhenghuiwang commented 4 years ago

/retest

jlewi commented 4 years ago

/lgtm /approve

/hold for @Bobgy

zhenghuiwang commented 4 years ago

Presubmit check looks good. It seems you should also exit 1 here. Did I miss anything?

You're right. Done. Thanks

jlewi commented 4 years ago

/lgtm /approve

/hold for @Bobgy

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/metadata/blob/master/OWNERS)~~ [neuromage] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Bobgy commented 4 years ago

/lgtm