Closed kwasi closed 4 years ago
This has no visual changes, but the changes are deployed to: https://kubeflow-ui-07.endpoints.kwasinti-kubeflow-dev.cloud.goog/_/metadata/
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: avdaredevil
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/area front-end /area metadata /assign @avdaredevil
This is a followup change to #183 to make it easier to migrate
LineageView
to a standalone repo. I'm working under the assumption that any file namedLineage*.tsx?
will be moved to the Lineage module of the shared-components repo.Changes
Css.tsx
intoLineageCss.ts
to eliminate a non-lineage dependency.cardWidth
andedgeWidth
props that are passed to LineageView and propagated down toLineageCard
andEdgeCanvas
<LineageView />
. The goal is to allow<ArtifactDetails />
the page/application to drive the sizes of the shared component<LineageView />
while providing reasonable defaults.This change is![Reviewable](https://reviewable.io/review_button.svg)