kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

Move LineageView key sizes to LineageView props #185

Closed kwasi closed 4 years ago

kwasi commented 4 years ago

/area front-end /area metadata /assign @avdaredevil

This is a followup change to #183 to make it easier to migrate LineageView to a standalone repo. I'm working under the assumption that any file named Lineage*.tsx? will be moved to the Lineage module of the shared-components repo.

Changes


This change is Reviewable

kwasi commented 4 years ago

This has no visual changes, but the changes are deployed to: https://kubeflow-ui-07.endpoints.kwasinti-kubeflow-dev.cloud.goog/_/metadata/

avdaredevil commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avdaredevil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/kubeflow/metadata/blob/master/frontend/OWNERS)~~ [avdaredevil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment