search

kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

MLMD SDK Notebook spelling nits #186

Closed avdaredevil closed 4 years ago

avdaredevil commented 4 years ago

About

A few quick spelling nits on the demo notebook for MLMD SDK.

Meta

/area metadata /area front-end /priority p1 /assign @avdaredevil /cc @kwasi @zhenghuiwang

This change is Reviewable

zhenghuiwang commented 4 years ago

/lgtm /approve /retest

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhenghuiwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[sdk/OWNERS](https://github.com/kubeflow/metadata/blob/master/sdk/OWNERS)~~ [zhenghuiwang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhenghuiwang commented 4 years ago

The presubmit test fails because of the failure of installing python3.6 on the testing worker. I will make a PR to fix it.

zhenghuiwang commented 4 years ago

@avdaredevil could you rebase this PR? The problematic test has been fixed.

avdaredevil commented 4 years ago

@zhenghuiwang done! PTAL :)

zhenghuiwang commented 4 years ago

/lgtm