kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

LineageView card loading updates #188

Closed kwasi closed 4 years ago

kwasi commented 4 years ago

/area front-end /area metadata /assign @avdaredevil /kind feature

Changes

Live: https://kubeflow-ui-07.endpoints.kwasinti-kubeflow-dev.cloud.goog/

Screenshots:

Before: https://screenshot.googleplex.com/4DYmxxC5csY https://screenshot.googleplex.com/Kbf9jzv74xu

After: https://screenshot.googleplex.com/KkG6qc4aJ9M https://screenshot.googleplex.com/3vuHpquEVWm

Note:

A follow-up will fetch executions for output artifacts to decide if the next dot should be shown for off-screen elements, but I will wait to optimize the queries loading the current view for larger data sets first.


This change is Reviewable

kwasi commented 4 years ago

Pushed latest to: https://kubeflow-ui-07.endpoints.kwasinti-kubeflow-dev.cloud.goog/_/metadata/

kwasi commented 4 years ago

/test kubeflow-metadata-presubmit

Errors look like the grpc server couldn't be reached. Could be flaky, so retesting.

E grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with: E status = StatusCode.UNAVAILABLE E details = "failed to connect to all addresses" E debug_error_string = "{"created":"@1576206476.993009144","description":"Failed to pick subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_li ne":3934,"referenced_errors":[{"created":"@1576206476.993002610","description":"failed to connect to all addresses","file":"src/core/ext/filters/client_channel/lb_policy/pickfirst/pick first.cc","file_line":393,"grpc_status":14}]}"

avdaredevil commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avdaredevil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/kubeflow/metadata/blob/master/frontend/OWNERS)~~ [avdaredevil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment