Use papermill to exec Notebook

[zhenghuiwang]

Parameterize demo notebook for python SDK with papermill for easy testing.

---

This change is 

[jinchihe]

Hey @zhenghuiwang Why not use pytest to execute papermill.execute_notebook function to test that as below, may be more simple. :-)

https://github.com/kubeflow/examples/blob/0d49548b3a4e4c1511b14272ae7d1b0b86e88612/xgboost_synthetic/testing/execute_notebook.py#L17

[zhenghuiwang]

/retest

[zhenghuiwang]

Hey @zhenghuiwang Why not use pytest to execute papermill.execute_notebook function to test that as below, may be more simple. :-)

https://github.com/kubeflow/examples/blob/0d49548b3a4e4c1511b14272ae7d1b0b86e88612/xgboost_synthetic/testing/execute_notebook.py#L17

Thanks! I guess pytest is easier to run as part of python tests instead of bash scripts. I made the change to use python API of papermill.

[zhenghuiwang]

/test kubeflow-metadata-presubmit

[zhenghuiwang]

@jinchihe could you take anther look? Thanks

[jinchihe]

That's great! @zhenghuiwang

/lgtm

[zhenghuiwang]

Thanks

/approve

On Mon, Dec 16, 2019 at 18:31 Jin Chi He notifications@github.com wrote:

That's great! @zhenghuiwang https://github.com/zhenghuiwang

/lgtm

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/kubeflow/metadata/pull/190?email_source=notifications&email_token=AB7BSKMQ247ACXYJ6TYPL5DQZA2X5A5CNFSM4J2GQO7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHA5RII#issuecomment-566352033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7BSKJZI5SGN73NOWGRQDDQZA2X5ANCNFSM4J2GQO7A .

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhenghuiwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/metadata/blob/master/OWNERS)~~ [zhenghuiwang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[jinchihe]

/retest

[jinchihe]

/lgtm