[MLMD Lineage] Style changes to scale view for normal laptop screens

kubeflow / metadata

Repository for assets related to Metadata.

Apache License 2.0

121 stars 69 forks source link

[MLMD Lineage] Style changes to scale view for normal laptop screens #199

Closed avdaredevil closed 4 years ago

avdaredevil commented 4 years ago

fixes #193 fixes #195

About

Changes to make the lineage view fit on a normal laptop screen:

Decreased width between columns
Decreased width of cards in columns
Decreased padding for title
Decreased font-sizes for title and main card row content
Decreased size of radio selector

Also updated CSS to show Mac-style scrollbars at all times.

Image

View with collapsed sidebar	Scroll Bar changes

Meta

/area metadata /area front-end /priority p1 /assign @avdaredevil /cc @kwasi

This change is

kwasi commented 4 years ago

Looks great! Do you know what the test failure is? The argo console doesn't show anything for me.

/lgtm /approve

avdaredevil commented 4 years ago

/retest

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwasi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/kubeflow/metadata/blob/master/frontend/OWNERS)~~ [kwasi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kwasi commented 4 years ago

/lgtm