[MLMD Lineage] Execution Grouping Support added for Lineage View

kubeflow / metadata

Repository for assets related to Metadata.

Apache License 2.0

121 stars 69 forks source link

[MLMD Lineage] Execution Grouping Support added for Lineage View #200

Closed avdaredevil closed 4 years ago

avdaredevil commented 4 years ago

fixes #196

About

This change removes the static Execution column handler with the dynamic types supported within Kubeflow (and groups by type). Feature changes:

Scan for Execution Types
Create a map between Execution type name and id
Group by Execution Type
Reverse build edges from Output Execs to Target
Linting warnings resolved
Code nits

Image

Grouped Execution Column with reverse edges

Meta

/area metadata /area front-end /priority p1 /assign @avdaredevil /cc @kwasi

This change is

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign avdaredevil You can assign the PR to them by writing /assign @avdaredevil in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/kubeflow/metadata/blob/master/frontend/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kwasi commented 4 years ago

/lgtm

k8s-ci-robot commented 4 years ago

New changes are detected. LGTM label has been removed.

avdaredevil commented 4 years ago

/retest

k8s-ci-robot commented 4 years ago

@avdaredevil: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
kubeflow-metadata-presubmit	6197707555a5a2c875f2079888ee3d280a93ccb9	link	`/test kubeflow-metadata-presubmit`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

avdaredevil commented 4 years ago

Errors seem irrelevant to PR now:

Unit tests passed! Merging.