kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

Error: secret "metadata-db-secrets" not found #204

Closed pdmack closed 4 years ago

pdmack commented 4 years ago

/kind bug

kfctl 1.0 rc0

These all fail to start due to the secret not being created.

NAME                                                           READY     STATUS                       RESTARTS   AGE
metadata-db-dc799559d-hmmcv                                    0/1       CreateContainerConfigError   0          27m
metadata-deployment-5bbd74644c-jpgkg                           0/1       CreateContainerConfigError   0          27m
metadata-grpc-deployment-6b5454dbbb-6k8vg                      0/1       CreateContainerConfigError   0          27m
benruland commented 4 years ago

Adding the secret generator to ./kustomize/metadata/kustomization.yaml works around this bug:

- name: metadata-db-secrets
  env: overlays/db/secrets.env
benruland commented 4 years ago

This might be caused by kubeflow/kfctl#156

Altair3 commented 4 years ago

running into this as well. Where exactly in ~/kustomization.yaml do I add those lines?

benruland commented 4 years ago

You can add it anywhere in the file ./kustomize/metadata/kustomization.yaml.

Note that the kustomize folder needs to be generated first, as described in https://www.kubeflow.org/docs/started/k8s/kfctl-existing-arrikto/#alternatively-set-up-your-configuration-for-later-deployment

marcindulak commented 4 years ago

Adding the secret generator to ./kustomize/metadata/kustomization.yaml works around this bug:

- name: metadata-db-secrets
  env: overlays/db/secrets.env

Didn't work for me (followed by kustomize build kustomize/metadata | kubectl apply -f -). It did not create the metadata-db-secrets secret.

Adding the following in kustomize/metadata/kustomization.yaml resulted in creation the metadata-db-secrets secret.

secretGenerator:
- behavior: unspecified
  name: metadata-db-secrets
  env: overlays/db/secrets.env

Note that recent kustomize (I'm using Version: {KustomizeVersion:3.0.0 GitCommit:e0bac6ad192f33d993f11206e24f6cda1d04c4ec BuildDate:2019-07-03T18:21:24Z GoOs:linux GoArch:amd64}) has troubles with env https://github.com/kubeflow/metadata/issues/202

I'm using https://github.com/kubeflow/manifests/blob/c4f51b1cc0b4854b6f6180d5a3bb021dd65691a8/kfdef/kfctl_k8s_istio.yaml with https://github.com/kubeflow/kfctl/releases/tag/v1.0-rc.2 on k8s v1.15.7

marcindulak commented 4 years ago

No more CreateContainerConfigError as in the original report with kustomize_3.0.0 on k8s v1.15.7 and https://github.com/kubeflow/kfctl/releases/tag/v1.0-rc.3 https://github.com/kubeflow/manifests/blob/bf518c8392f377c47911b09a1dbeac3dbb051d9e/kfdef/kfctl_k8s_istio.v1.0.0.yaml https://github.com/kubeflow/kubeflow/commit/3ec0de71c1bcb1d1d81c43fa62fa6f9e9e174db2

zhenghuiwang commented 4 years ago

Duplicate of https://github.com/kubeflow/kfctl/issues/156

Fixed in kfclt v1rc3 release.

stomplee commented 4 years ago

I have this same issue with the latest AWS kfdef and kfctl v1.0-0-g94c35cf. Had to use the fix above to resolve.