[MLMD Lineage] Integrate LineageView changes to add navigation to card resources

kubeflow / metadata

Repository for assets related to Metadata.

Apache License 2.0

121 stars 69 forks source link

[MLMD Lineage] Integrate LineageView changes to add navigation to card resources #211

Closed kwasi closed 4 years ago

kwasi commented 4 years ago

/assign @kwasi /cc @avdaredevil /area metadata /area front-end

Adds changes from kubeflow/frontend to make LineageCardRow titles link to Lineage resource details page
Pass route builder into LineageView from ArtifactDetails

Validation

Deployment: https://kubeflow-ui-07.endpoints.kwasinti-kubeflow-dev.cloud.goog/

This change is

kwasi commented 4 years ago

/hold

This PR is ready for review but needs https://github.com/kubeflow/frontend/pull/22 to be merged first so one more commit to bump the hash in package.json can be made.

kwasi commented 4 years ago

/hold cancel

kwasi commented 4 years ago

Ready for review and pushed new working docker image.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avdaredevil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/kubeflow/metadata/blob/master/frontend/OWNERS)~~ [avdaredevil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

avdaredevil commented 4 years ago

Hey @kwasi There are a few comments on this PR. So once you get a chance to go through them, I can review / leave an lgtm.

kwasi commented 4 years ago

@avdaredevil This PR should be ready to go. I've also updated to the latest hash and updated the deployment.