kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

SDK Version 0.3.0 not working properly with MLMD v0.21.1 (1.0.0rc) because of `ml-metadata==0.15.0` pinned dependency #213

Closed rafbarr closed 4 years ago

rafbarr commented 4 years ago

/kind bug

What steps did you take and what happened:

Execute demo notebook. At the end:

>>> store = metadata.Store(grpc_host=METADATA_STORE_HOST, grpc_port=METADATA_STORE_PORT)
>>> store.store.get_artifacts_by_uri('gcs://my-bucket/mnist')
[]

At this point, get_artifacts_by_uri should return the model artifact created by the notebook. This used to work with MLMD gRPC server v0.15.1. The get_artifacts_by_uri works using ml-metadata==0.21.1 Python library. However, this breaks the Kubeflow SDK because it requires 0.15.0.

What did you expect to happen:

store.store.get_artifacts_by_uri('gcs://my-bucket/mnist') should work just fine.

Anything else you would like to add:

Environment:

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-07T09:55:27Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.8-gke.33", GitCommit:"2c6d0ee462cee7609113bf9e175c107599d5213f", GitTreeState:"clean", BuildDate:"2020-01-15T17:47:46Z", GoVersion:"go1.12.11b4", Compiler:"gc", Platform:"linux/amd64"}
issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
bug 0.99

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

rafbarr commented 4 years ago

@jlewi The reason for this to be marked as a bug is that as per README, version 0.3.0 should work with Kubeflow 1.0.0. However https://github.com/kubeflow/manifests/pull/937 breaks it.

zhenghuiwang commented 4 years ago

/assign @zhenghuiwang