search

kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

Bump MLMD Python library so as to match Kubeflow 1.0rc #214

Closed rafbarr closed 4 years ago

rafbarr commented 4 years ago

What this PR does / why we need it:

Current version 0.3.0 is supposed to work with Kubeflow 1.0. However, recently MLMD gRPC server has been updated to 0.21.1 in the manifests. This is incompatible with the MLMD Python SDK version 0.15.1 used by version 0.3.0. Therefore, in order to fix it, this PR bumps MLMD Python SDK version to 0.21.1 as well and fixes any issues related to it. The details is described in issue #213.

Which issue(s) this PR fixes:

Fixes #213

Special notes for your reviewer:

Release note:

Update MLMD Python SDK to 0.21.1 so as to match [Kubeflow 1.0 version](https://github.com/kubeflow/manifests/pull/937) (Fixes #213).

This change is Reviewable

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

k8s-ci-robot commented 4 years ago

Hi @rafaelbarreto87. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jinchihe commented 4 years ago

/ok-to-test

rafbarr commented 4 years ago

@jinchihe I'm unclear on the test error:

Parsing ApiException body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Unauthorized","reason":"Unauthorized","code":401}

Do you know what the problem is?

zhenghuiwang commented 4 years ago

/retest

zhenghuiwang commented 4 years ago

/lgtm /approve

Thanks!

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhenghuiwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[sdk/OWNERS](https://github.com/kubeflow/metadata/blob/master/sdk/OWNERS)~~ [zhenghuiwang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 years ago

@rafaelbarreto87: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-metadata-presubmit 2f6c1ed86e4ce8a30da7d00f358b2192c63f1ff6 link /test kubeflow-metadata-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zhenghuiwang commented 4 years ago

@rafaelbarreto87 I think you need to delete one unit test and update the license file in order to pass the tests.

I encounter these failures in another PR https://github.com/kubeflow/metadata/pull/215

rafbarr commented 4 years ago

Oh. So it looks like that PR already fixes the same issue. If that is landing, we can ignore this.

zhenghuiwang commented 4 years ago

Duplicate of #215