kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

[MLMD] Final updates to lineage view #216

Closed avdaredevil closed 4 years ago

avdaredevil commented 4 years ago

About

Updated metadata to master upstream changes from kubeflow/frontend, refactored imports

Meta

/area metadata /area front-end /priority p0 /assign @avdaredevil /cc @kwasi @jlewi


This change is Reviewable

avdaredevil commented 4 years ago

Errors seem irrelevant: image

k8s-ci-robot commented 4 years ago

@avdaredevil: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-metadata-presubmit 7e467e4e6f68c42a6fd3a86070d268813165dafd link /test kubeflow-metadata-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kwasi commented 4 years ago

Looks good!

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwasi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/kubeflow/metadata/blob/master/frontend/OWNERS)~~ [kwasi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
avdaredevil commented 4 years ago

The same issue again, merging... image