search

kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 67 forks source link

Fix a typo in metadata sample notebook #242

Open danielsiwiec opened 4 years ago

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

kubeflow-bot commented 4 years ago

This change is Reviewable

k8s-ci-robot commented 4 years ago

Hi @danielsiwiec. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Bobgy commented 4 years ago

/lgtm /approve Thank you for the fix!

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Bobgy, danielsiwiec To complete the pull request process, please assign gaoning777 after the PR has been reviewed. You can assign the PR to them by writing /assign @gaoning777 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[sdk/OWNERS](https://github.com/kubeflow/metadata/blob/master/sdk/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 years ago

@danielsiwiec: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-metadata-presubmit 8dbe3b2d8c9886dc8d7ff3661faaa7b037c0aa41 link /test kubeflow-metadata-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Bobgy commented 4 years ago

I'm sorry, this repo is pretty much in an abandoned state. We'll continue to evolve the metadata story, but may not be based on this repo. If presubmit is broken, then we won't accept any new PRs.

danielsiwiec commented 3 years ago

/retest

k8s-ci-robot commented 3 years ago

@danielsiwiec: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubeflow/metadata/pull/242#issuecomment-754358327): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.